reorganize boardloader code #4564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[no changelog]
|
TychoVrahe
force-pushed
the
tychovrahe/boardloader/refactor
branch
from
8ac98ad to
f77d5ed
Compare
cepetr
requested changes
Feb 5, 2025
| term_printf("\ndone\n\n"); | ||
| term_printf("Unplug the device and remove the SD card\n"); | ||
|
|
||
| return sectrue; |
There was a problem hiding this comment.
We should conditionally deinitialize the display at the end of copy_sdcard.
#ifdef FIXED_HW_DEINIT
display_deinit();
#endif
There was a problem hiding this comment.
for simplicity, i moved the init deinit to the caller, sd_update_check_and_update. Though we end up in reboot_or_halt_after_rsod in anyway.
cepetr
approved these changes
Feb 6, 2025
[no changelog]
[no changelog]
…lays [no changelog]
TychoVrahe
force-pushed
the
tychovrahe/boardloader/refactor
branch
from
11db11f to
f08eb5e
Compare
cepetr
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reorganizes boardloader code: mainly SD card update functionality is separated into its own file, which allows easier reading of the main code.
Lazy initialization of display driver is introduced, to allow faster boot times. However, this is now enabled only for some models, as some bootloaders rely on display already being initialized. This is now fixed, as bootloader should always reinitialize the driver (and bootloader should deinitiliaze it on exit, which it luckily does incompletely - otherwise such bootloaders woudn't work properly.