Popover component for floating content next to a target element #16481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izmy
force-pushed
the
feat/popover-component
branch
4 times, most recently
from
24ada5f to
8c168a2
Compare
jvaclavik
reviewed
Jan 24, 2025
| ); | ||
| }); | ||
|
|
||
| export function Popover({ |
There was a problem hiding this comment.
offtopic: shouldn't we also abstract Tooltip to Popover similarly like Dropdown? Does it make sense? WDYT?
There was a problem hiding this comment.
Well, Tootip has a similar implementation, because it also uses @floating-ui/react, so I think it makes sense for me.
packages/suite/src/components/suite/layouts/SuiteLayout/Sidebar/NavigationItem.tsx
Outdated
Show resolved
Hide resolved
izmy
force-pushed
the
feat/popover-component
branch
from
5c275fd to
4db6013
Compare
izmy
force-pushed
the
feat/popover-component
branch
from
4db6013 to
80fc82f
Compare
izmy
force-pushed
the
feat/popover-component
branch
from
d9e8512 to
ee8217b
Compare
|
/rebase |
|
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/13010996511 |
|
Rebasing failed, please rebase manually. |
izmy
force-pushed
the
feat/popover-component
branch
from
ee8217b to
641394f
Compare
tomasklim
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the dropdown could render outside the viewport, particularly on smaller screens. So I created a new Popover component to keep content within the viewport. The component monitors whether the content is visible and dynamically adjusts its position when necessary. I used the
@floating-ui/reactlibrary for this functionality, which is already used for tooltips.I also refactored the
Dropdowncomponent, then separated theMenufile, and created an example in the storybook.Related Issue
Resolve #12939
Screenshots: