Refactor pipeline #964
Merged
Refactor pipeline #964
+226
−277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squell
force-pushed
the
refactor-pipeline
branch
7 times, most recently
from
4deb268 to
231cf3f
Compare
bjorn3
reviewed
Feb 3, 2025
squell
force-pushed
the
refactor-pipeline
branch
from
231cf3f to
222f138
Compare
bjorn3
approved these changes
Feb 3, 2025
…mplifying the traits quite a bit
squell
force-pushed
the
refactor-pipeline
branch
from
7404db2 to
bd57640
Compare
squell
force-pushed
the
refactor-pipeline
branch
from
bd57640 to
1feff85
Compare
bjorn3
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some anticipated generalisation (and thus abstraction) of the pipeline which never materialized (e.g. using the same pipeline for sudo, su and a potential doas-rs), since su and sudo were too different.
This got in the way of implementing #61 and also made the code sometimes hard to change
In the future, as sudo-rs gets more functionality, introducing this generalization isn't a bad idea, but then it's better to do that based on the actual needs instead of the pre-planned needs of the implementations.
Take no thought for the morrow: for the morrow shall take thought for the things of itself.
Preparatory part of #61