Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed CI Test Action Issue #231

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Fixed CI Test Action Issue #231

merged 2 commits into from
Feb 11, 2025

Conversation

dzodkin33
Copy link
Contributor

Fixed CI not able to pull udp_squared and protos.

@miyatakazuya miyatakazuya self-requested a review February 8, 2025 01:59
miyatakazuya
miyatakazuya approved these changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@miyatakazuya miyatakazuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github actions running as expected. LGTM

@miyatakazuya miyatakazuya self-requested a review February 8, 2025 23:18
@AskewParity AskewParity self-requested a review February 8, 2025 23:18
AskewParity
AskewParity requested changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@AskewParity AskewParity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what this fixes, I am aware that

  • in previous commits, there was an issue with pulling these tests
  • there is no issue now in the main branch, we have already messed with the GH actions

@dzodkin33
Copy link
Contributor Author

@AskewParity

  1. The error with Test CI indicated it wasn't able to pull udp_squared.
  2. Additionally, Pull Submodules became somewhat obsolete since all GitHub repos are now public.

AskewParity
AskewParity approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@AskewParity AskewParity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think on net this is good to simplify the code.

However, I still don't think this solves the issue (as the issue was solved already)

@AskewParity AskewParity merged commit da80b2c into main Feb 11, 2025
3 checks passed
@AskewParity AskewParity deleted the bug/fix-ci branch February 11, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AskewParity AskewParity AskewParity approved these changes

@miyatakazuya miyatakazuya Awaiting requested review from miyatakazuya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dzodkin33 @miyatakazuya @AskewParity