server: optimize masternodes api #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server: masternode syncing conditionally (enabled/disabled) server: improve PR (optimize masternodes api) #185 - MasternodeRepository, MasternodeSynchronizerActor in seperated file - bind MasternodeRepository and its ActorImpl - Right now, have an issue with Cyclic Reference - fix compiler error - handle MasternodeNotFoundError Code Style - Added second MasternodesControllerSpec2 for testing - ScalaFmt server: masternodes testing added server: MasternodesControllerSpec2 removed MasternodesControllerSpec class name typo server: optimize masternodes api minor updates - disable ActorsModule while testing - get -> getAll, getOne -> find - other minor updates enable the ActorsModule in testing - unused import issue fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server: masternode syncing conditionally (enabled/disabled)
server: improve PR (optimize masternodes api) wiringbits#185
MasternodeRepository, MasternodeSynchronizerActor in seperated file
bind MasternodeRepository and its ActorImpl
Right now, have an issue with Cyclic Reference
fix compiler error
handle MasternodeNotFoundError
Code Style
server: masternodes testing added
server: MasternodesControllerSpec2 removed
MasternodesControllerSpec class name typo
server: optimize masternodes api minor updates
enable the ActorsModule in testing
Problem
Explain the context and why you're making that change. What is the
problem you're trying to solve? In some cases there is not a problem
and this can be thought of being the motivation for your change.
Solution
Describe the modifications you've done.
Result
What will change as a result of your pull request? Note that sometimes
this section is unnecessary because it is self-explanatory based on
the solution.
If you changed the UI, please include screenshots.