feat: get gitlog by command #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tansu canceled.
|
✅ Deploy Preview for testnet-tansu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tupui
requested changes
Jan 28, 2025
| setLoading(true); | ||
| setError(""); | ||
| console.log("author", projectRepoInfo.author) | ||
| console.log("repo", projectRepoInfo.repository) |
|
|
||
|
|
||
|
|
||
| // import React from "react"; |
| commits: commits as FormattedCommit[], | ||
| })); | ||
| } | ||
| // async function getCommitHistory( |
There was a problem hiding this comment.
To be deleted an not commented if not used anymore
| setError(""); | ||
| console.log("author", projectRepoInfo.author) | ||
| console.log("repo", projectRepoInfo.repository) | ||
| const response = await axios.get(`/api/commits?username=${projectRepoInfo.author}&repo=${projectRepoInfo.repository}`) |
There was a problem hiding this comment.
To be clear, I don't want to have a backend API. Fetching the repo has to happen client side and be cached there.
tupui
added
enhancement
0xExp-po
reviewed
Jan 30, 2025
| export async function GET({ url }) { | ||
| console.log("url", url); | ||
| const username = "tupui"; | ||
| const repo = "soroban-versioning"; |
There was a problem hiding this comment.
These values is hard coded here
| // const repo = params.get('repo') | ||
|
|
||
| console.log("username", username); | ||
| console.log("repo", repo); |
There was a problem hiding this comment.
Please remove unnecessary console log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use git cmd to fetch git commit history instead of github api