BE Refactor Contacts Controller to Delegate Business Logic to Models

[CCirbo]

• Move business logic, such as fetching associated companies and contacts, into model methods to follow the Fat Model, Skinny Controller principle.

• Refactor the ContactsController to focus only on:
• Authenticating users.
• Authorizing resources.
• Formatting responses.

[Crosswolfv1]

Description

Refactor Contacts controller and associated model

Motivation and Context

Refactored needed to adhere to skinny controller, fat model guidelines.

Screenshots (if appropriate):

Types of changes

• Code Cleanup (code refactor)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

1. Identify Methods on controller needing to be moved to model

• Index: Move find by's into relate models i.e looking for a company move to company model
• Create: Use same find by model method as index
• Create: create in contact model method to create contacts when company is true potentially combine with create w/o default nil/null company id
• Show: create model method on contacts to find user and contact

2. move methods and refactor as needed
3. Add new model tests
4. Verify/Fix old tests still pass

[epintozzi]

Oh interesting I like the approach of using the PR template as a template for breaking down your problem