Refactor/contacts controller #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor/contacts-controller
…tor/contacts-controller
…tor/contacts-controller
…d error serializer
…erializer for standarized error handling
…ORO and Error serializer
bwillett2003
reviewed
Feb 7, 2025
| end | ||
| expect(json[:message]).to include("Contact not found") | ||
| expect(json[:status]).to eq(404) | ||
| end |
There was a problem hiding this comment.
I honestly think I did the same thing. I used the error serializer for my update method and had to go back and refactor all of my tests, good work.
bwillett2003
reviewed
Feb 7, 2025
| else | ||
| return false | ||
| end | ||
| end |
There was a problem hiding this comment.
I like the helper method checking if a company exists. If a company doesn't exist then that contact won't either since contacts belong to a company.
There was a problem hiding this comment.
I added that to company as a helper method to retrieve a company to return a false if company is not found for the index contacts endpoint, I feel like it belongs there instead of the contacts model due to SRP
bwillett2003
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Refactor Contacts controller and associated model
Motivation and Context
Refactored needed to adhere to skinny controller, fat model guidelines.
Related Tickets
#58
Screenshots (if appropriate):
Added Test?
Checklist: