Add WhoisDns File #142
Open
Add WhoisDns File #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add WhoisDnsModel file
twodayslate
reviewed
Jan 18, 2024
| import StoreKit | ||
| import SwiftyStoreKit | ||
|
|
||
| final class WhoisDns: DataFeedSingleton { |
There was a problem hiding this comment.
Rename to SwiftWhois? DNS == Domain Name System
twodayslate
reviewed
Jan 18, 2024
| public static var lookupService: IPLookupService = .init() | ||
|
|
||
| class IPLookupService: Service { | ||
| var name: String = "Simple IP Lookup" |
There was a problem hiding this comment.
var name: String = "Simple IP Lookup" -> var name: String = "Simple Whois Lookup"
twodayslate
reviewed
Jan 18, 2024
| return | ||
| } | ||
|
|
||
| DNSResolver.resolve(host: host) { error, addresses in |
There was a problem hiding this comment.
You are supposed to use https://swiftpackageregistry.com/isaced/SwiftWhois
twodayslate
requested changes
Jan 18, 2024
There was a problem hiding this comment.
Use https://swiftpackageregistry.com/isaced/SwiftWhois and use it's data
Remove DnsResolver from FreeSwiftWhois class Add SwiftWhois.lookup in FreeSwiftWhois query metod Remove Addresss array from FreeSwiftWhois Model and response model for whoisData Create Codeable Model For WhoisData
Pass whoisData into Content Model
twodayslate
reviewed
Jan 25, 2024
| @@ -5,6 +5,7 @@ import Foundation | |||
| import KeychainAccess | |||
| import StoreKit | |||
| import SwiftyStoreKit | |||
| import SwiftWhois | |||
twodayslate
reviewed
Jan 25, 2024
| @@ -45,6 +46,9 @@ extension LocalDns: DataFeedService { | |||
| return | |||
| } | |||
|
|
|||
| do { | |||
twodayslate
reviewed
Jan 25, 2024
| throw URLError(.badURL) | ||
| } | ||
|
|
||
| return try await withCheckedThrowingContinuation { continuation in |
twodayslate
reviewed
Jan 25, 2024
| } | ||
|
|
||
| return try await withCheckedThrowingContinuation { continuation in | ||
| Task { |
twodayslate
reviewed
Jan 25, 2024
| import SwiftWhois | ||
|
|
||
|
|
||
| struct FreeSwiftWhoisDataModel: Codable { |
There was a problem hiding this comment.
Why do we need this? Let's make the actual content Codable
twodayslate
reviewed
Jan 25, 2024
| let copyData = try JSONEncoder().encode(dataModel) | ||
| latestData = copyData | ||
| dataToCopy = String(data: copyData, encoding: .utf8) | ||
| content.append(.row(title: "Domain", content: dataModel.domainName ?? "")) |
There was a problem hiding this comment.
If the data is missing let's just not display it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add WhoisDnsModel file
Closes #140