Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more stars #28

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add more stars #28

wants to merge 5 commits into from

Conversation

T0mstone
Copy link
Collaborator

@T0mstone T0mstone commented Jan 21, 2025

I'm happy to receive any feedback about the names.

Unicode Weirdness

Four-pointed Stars

There's two black four-pointed stars,

  • U+2726 "Black Four Pointed Star"
  • U+1F7C6 "Four Pointed Black Star"
    I chose to go with the second one since the first one is from the "Dingbats" block, not from "Geometric Shapes Extended".
    There's also U+2727 "White Four Pointed Star", which I haven't added since it'd be weirdly inconsistent.

Edit: The source (mentioned below) says "2726 ✦ is a cusp", so not having it or 2727 as stars is probably correct.

Five-pointed Stars

I'm assuming the original star is intended to be five-pointed (but idk how much of this is just fonts agreeing with each other rather than Unicode actually saying something about it. Where do you get all that secret Unicode information about how characters are supposed to look?)

In particular, note how there's U+1F7C9 "Light Five Pointed Black Star" and U+1F7CA "Heavy Five Pointed Black Star", but no plain "Five Pointed Black Star".
There's also U+066D "Arabic Five Pointed Star", which I don't know what to do with.

Currently, I've added the former two as star.filled.{light, heavy}.

Edit: I found the official source: https://www.unicode.org/charts/PDF/U1F780.pdf
It says

Constitute a set as follows: 1F7C9, 2605, 1F7CA, and 272F

So attaching them without an extra qualifier is correct.

Eight-pointed Stars

U+1F7D0 is called "Very Heavy Eight Pointed Black Star". What do we call this modifier? I've gone with veryheavy for now, but I don't think this is a good choice.

Variation Selectors

https://www.unicode.org/Public/8.0.0/ucd/StandardizedVariants.html has an entry for U+2734 (star.eight.filled), so it should get a VS15 when #25 is resolved.

My font shows U+1F52F "Six Pointed Star with Middle Dot" in emoji style by default. VS15 does work, but this isn't listed in the above table. Is this a nonstandard variant?
Regardless, it should then also get a VS15.

@T0mstone
Copy link
Collaborator Author

Should I also add the "asterisk" symbols? (e.g. U+1F7AF 🞯 "LIGHT FIVE SPOKED ASTERISK") They're not really "punctuation" like the current sym.ast, but they're not officially "stars"...

Copy link
Collaborator

@MDLC01 MDLC01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some thoughts in the review comments.

Additionally, maybe U+2726 ✦ should be added as star.cusp, star.filled.cusp, or star.four.filled.cusp.

Moreover, I'm not sure I understand why you said that "attaching them without an extra qualifier is correct" given that the charts mention, as you noted, that five pointed stars constitute a set containing U+1F7C9, U+2605, U+1F7CA, and U+272F.

@@ -713,7 +713,52 @@ parallelogram
star
.op ⋆
.stroked ☆
.stroked.small ⭒
.stroked.outlined ⚝
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like .outlined, but I don't have a good alternative either.

src/modules/sym.txt Outdated Show resolved Hide resolved
src/modules/sym.txt Outdated Show resolved Hide resolved
src/modules/sym.txt Outdated Show resolved Hide resolved
src/modules/sym.txt Outdated Show resolved Hide resolved
@T0mstone
Copy link
Collaborator Author

T0mstone commented Jan 24, 2025

Moreover, I'm not sure I understand why you said that "attaching them without an extra qualifier is correct" given that the charts mention, as you noted, that five pointed stars constitute a set containing U+1F7C9, U+2605, U+1F7CA, and U+272F.

Note how U+2605 is just star.filled. Another idea would be renaming that to star.five.filled, then the other ones could follow suit. In that case, we could also rename the pentagram to star.five.something, tho I don't really like star.five.stroked since the strokes cross each other rather than being an outline only.

Same with star.six.david; That one is a well-established symbol (i.e. the name already makes it clear), so it might be fine to treat it as the six-pointed equivalent to the pentagram.

@T0mstone
Copy link
Collaborator Author

Additionally, maybe U+2726 ✦ should be added as star.cusp, star.filled.cusp, or star.four.filled.cusp.

In that case we should also add all the other cusps. There are more of them and I was thinking of leaving them for later.

@T0mstone
Copy link
Collaborator Author

There, I've added the .five modifier to all the regular stars (except for .op, which I feel is supposed to be more abstract), since the regular star.filled is (by association) five-pointed, and thus (tho I'm not perfectly sure about this) all its plain derivatives can be assumed to be five-pointed as well.

I then went and made the david star and the pentagram the same modifier, namely .crossing, since the strokes are crossing each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants