-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more stars #28
base: main
Are you sure you want to change the base?
Add more stars #28
Conversation
Should I also add the "asterisk" symbols? (e.g. U+1F7AF 🞯 "LIGHT FIVE SPOKED ASTERISK") They're not really "punctuation" like the current |
See https://www.unicode.org/charts/PDF/U1F300.pdf, which links U+1F52F to U+2721.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some thoughts in the review comments.
Additionally, maybe U+2726 ✦ should be added as star.cusp
, star.filled.cusp
, or star.four.filled.cusp
.
Moreover, I'm not sure I understand why you said that "attaching them without an extra qualifier is correct" given that the charts mention, as you noted, that five pointed stars constitute a set containing U+1F7C9, U+2605, U+1F7CA, and U+272F.
src/modules/sym.txt
Outdated
@@ -713,7 +713,52 @@ parallelogram | |||
star | |||
.op ⋆ | |||
.stroked ☆ | |||
.stroked.small ⭒ | |||
.stroked.outlined ⚝ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like .outlined
, but I don't have a good alternative either.
Note how U+2605 is just Same with |
In that case we should also add all the other cusps. There are more of them and I was thinking of leaving them for later. |
There, I've added the I then went and made the david star and the pentagram the same modifier, namely |
I'm happy to receive any feedback about the names.
Unicode Weirdness
Four-pointed Stars
There's two black four-pointed stars,
I chose to go with the second one since the first one is from the "Dingbats" block, not from "Geometric Shapes Extended".
There's also U+2727 "White Four Pointed Star", which I haven't added since it'd be weirdly inconsistent.
Edit: The source (mentioned below) says "2726 ✦ is a cusp", so not having it or 2727 as stars is probably correct.
Five-pointed Stars
I'm assuming the original star is intended to be five-pointed (but idk how much of this is just fonts agreeing with each other rather than Unicode actually saying something about it. Where do you get all that secret Unicode information about how characters are supposed to look?)In particular, note how there's U+1F7C9 "Light Five Pointed Black Star" and U+1F7CA "Heavy Five Pointed Black Star", but no plain "Five Pointed Black Star".
There's also U+066D "Arabic Five Pointed Star", which I don't know what to do with.
Currently, I've added the former two as
star.filled.{light, heavy}
.Edit: I found the official source: https://www.unicode.org/charts/PDF/U1F780.pdf
It says
So attaching them without an extra qualifier is correct.
Eight-pointed Stars
U+1F7D0 is called "Very Heavy Eight Pointed Black Star". What do we call this modifier? I've gone with
veryheavy
for now, but I don't think this is a good choice.Variation Selectors
https://www.unicode.org/Public/8.0.0/ucd/StandardizedVariants.html has an entry for U+2734 (
star.eight.filled
), so it should get a VS15 when #25 is resolved.My font shows U+1F52F "Six Pointed Star with Middle Dot" in emoji style by default. VS15 does work, but this isn't listed in the above table. Is this a nonstandard variant?
Regardless, it should then also get a VS15.