doc(App.Run): Clarify exit code #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user expressed confusion about the exit code of an Fx application that was interrupted with Ctrl-C. Clarify in the documentation that the exit code will be non-zero only if there was a failure, or if Shutdown specifically requested a non-zero exit code.
r-hang
approved these changes
Jan 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1254 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 35 35
Lines 3336 3336
=======================================
Hits 3290 3290
Misses 39 39
Partials 7 7 ☔ View full report in Codecov by Sentry. |
|
lint failure unrelated |
|
Fixing lint issue here: #1255 |
sywhang
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user expressed confusion about the exit code of an Fx application
that was interrupted with Ctrl-C.
Clarify in the documentation that the exit code will be non-zero
only if there was a failure, or if Shutdown specifically requested
a non-zero exit code.