Skip to content

Commit

Permalink
CI: Additional fixes.
Browse files Browse the repository at this point in the history
* Remove a stray PDM reference left over in nox config.
* Turn off the "clean" operation in CI (unneeded).
* Turn off check-manifest job in CI (redundant).
* Turn off the git contributor scan in docs spellcheck.
  • Loading branch information
ubernostrum committed Oct 31, 2024
1 parent 95ff136 commit 2bcdbbc
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
4 changes: 4 additions & 0 deletions docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,10 @@
# Location of word list.
spelling_word_list_filename = "spelling_wordlist.txt"

# The documentation does not include contributor names, so we skip this because it's
# flaky about needing to scan commit history.
spelling_ignore_contributor_names = False

# OGP metadata configuration.
ogp_enable_meta_description = True
ogp_site_url = "https://django-registration.readthedocs.io/"
Expand Down
7 changes: 6 additions & 1 deletion noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ def clean(paths: typing.Iterable[pathlib.Path] = ARTIFACT_PATHS) -> None:
Clean up after a test run.
"""
# This cleanup is only useful for the working directory of a local checkout; in CI
# we don't need it because CI environments are ephemeral anyway.
if IS_CI:
return
[
shutil.rmtree(path) if path.is_dir() else path.unlink()
for path in paths
Expand Down Expand Up @@ -305,7 +309,6 @@ def lint_pylint(session: nox.Session) -> None:
"""
# Pylint requires that all dependencies be importable during the run, so unlike
# other lint tasks we just install the package.
session.run_always("pdm", "install", "-dG", "tests", external=True)
session.install("pylint", "pylint-django")
session.run(f"python{session.python}", "-Im", "pylint", "--version")
session.run(f"python{session.python}", "-Im", "pylint", "src/", "tests/")
Expand Down Expand Up @@ -363,6 +366,8 @@ def package_manifest(session: nox.Session) -> None:
control.
"""
if IS_CI:
session.skip("check-manifest already run by earlier CI steps.")
session.install("check-manifest")
session.run(
f"{session.bin}/python{session.python}", "-Im", "check_manifest", "--version"
Expand Down

0 comments on commit 2bcdbbc

Please sign in to comment.