Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use import for just #179

Merged
merged 3 commits into from
Jan 4, 2024
Merged

fix: Use import for just #179

merged 3 commits into from
Jan 4, 2024

Conversation

KyleGospo
Copy link
Member

@KyleGospo KyleGospo commented Dec 26, 2023

Fixes #178

@castrojo
Copy link
Member

This one will be critical so let's take our time testing this one!

@castrojo
Copy link
Member

This is tracking the just update in Fedora, so we should time it when it lands: https://bodhi.fedoraproject.org/updates/FEDORA-2023-4bdb1708ac

@KyleGospo KyleGospo force-pushed the KyleGospo-patch-1 branch 4 times, most recently from b6ab2b8 to 2a54806 Compare December 26, 2023 07:26
@ragazenta
Copy link

ragazenta commented Dec 27, 2023

Emm, sorry but it should be import (without !) and should use quote for path.

@KyleGospo KyleGospo force-pushed the KyleGospo-patch-1 branch 2 times, most recently from f0a0640 to cb13ffe Compare December 28, 2023 08:50
@KyleGospo
Copy link
Member Author

Emm, sorry but it should be import (without !) and should use quote for path.

Thanks, that should be corrected now.

@castrojo
Copy link
Member

Here's all the places we use just --unstable, we should probably clean all this up?

@p5
Copy link
Member

p5 commented Jan 4, 2024

Here's all the places we use just --unstable, we should probably clean all this up?

@castrojo
Completed in 299ed11

I kept ujust because I feel the u may stand for "unstable"? Otherwise there's not much point in ujust

Copy link
Member

@EyeCantCU EyeCantCU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here looks good! 1.18.1 just landed in the main images

@castrojo
Copy link
Member

castrojo commented Jan 4, 2024

We should just drop ujust as a verb now that we have this. Though that, is a fight for another day lol!

@castrojo castrojo enabled auto-merge January 4, 2024 17:10
@castrojo castrojo added this pull request to the merge queue Jan 4, 2024
Merged via the queue into main with commit de4e904 Jan 4, 2024
2 checks passed
@castrojo castrojo deleted the KyleGospo-patch-1 branch January 4, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate justfiles to import
5 participants