Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(just): toggle-nvk now supports nvidia-open #356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ledif
Copy link

@ledif ledif commented Feb 1, 2025

Fixes ublue-os/aurora#157.

Before

Image Name Rebase Target Is Valid Target
aurora-dx-nvidia aurora-dx
aurora-dx aurora-dx-nvidia
aurora-dx-nvidia-open aurora-dx-open

After

Image Name Rebase Target Is Valid Target
aurora-dx-nvidia aurora-dx
aurora-dx aurora-dx-nvidia-open
aurora-dx-nvidia-open aurora-dx

HikariKnight
HikariKnight previously approved these changes Feb 7, 2025
@HikariKnight
Copy link
Member

Thanks for this, when the toggle-nvk recipe was made, nvidia-open was like a year away from existing

@francoism90
Copy link

It would be great to test this out. :)

Copy link
Member

@m2Giles m2Giles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does mean that it won't rebase back to non-open Nvidia drivers.

@HikariKnight HikariKnight dismissed their stale review February 9, 2025 14:31

possibly add nvidia-legacy-hardware check from bazzite

@HikariKnight
Copy link
Member

HikariKnight commented Feb 9, 2025

in bazzite we have /usr/libexec/nvidia-legacy-hardware which will exit 0 (true) or exit 1 (false) depending on the user having legacy nvidia hardware.

We were going to originally use it to automatically rebase nvidia users with newer gpus to the nvidia-open image, but i am unsure if kyle ever did that.

this is the script

#!/usr/bin/bash
# Returns true if legacy nvidia hardware (older than turing) using die names
# GK### (Kepler), GM### (Maxwell), GP### (Pascal), GV### (Volta)
if lspci -nn | grep -P "(VGA compatible|3D) controller .+G(K|M|P|V)\d{3}" > /dev/null; then
    exit 0
fi
exit 1

this way we can make the toggle fail on legacy hardware, also unsure if Tesla cards will count as legacy, i could not find any proper info about that when i first made the script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nvidia-open breaks toggle-nvk
4 participants