-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React Update: 16 -> 18.3.1 #984
Conversation
…ocal and one general. I've renamed the local one "handleSingleIssueSave".
The responsiveness issues are still there. Although things seem to save. I'm still working out that, and the most recent issue is |
Some things to note for future reference:
That said, they're not breaking changes and we benefit from adding this to |
Can't seem to recreate this issue but will keep in mind for if the issue shows up on |
On second thought, it would be simpler to just update the |
Based on the React 18 Upgrade Guide, I made some minor changes to the
index.js
andApp.js
files to render the React app itself. But the biggest change is that React now recommends defining components as functions instead of classes. This involved addinguseState()
state variables, converting lifecycle hooks touseEffect()
functions, and destructuring props.While I tried to maintain the vast majority of the functionality in every component, there are a few issues (like the reports not rendering properly). I figure that this isn't a real cause for concern, since most of these components will likely be rewritten in the next few months based on the new UX.