Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Update: 16 -> 18.3.1 #984

Merged
merged 4 commits into from
Feb 5, 2025
Merged

React Update: 16 -> 18.3.1 #984

merged 4 commits into from
Feb 5, 2025

Conversation

mbusch3
Copy link

@mbusch3 mbusch3 commented Jan 24, 2025

Based on the React 18 Upgrade Guide, I made some minor changes to the index.js and App.js files to render the React app itself. But the biggest change is that React now recommends defining components as functions instead of classes. This involved adding useState() state variables, converting lifecycle hooks to useEffect() functions, and destructuring props.

While I tried to maintain the vast majority of the functionality in every component, there are a few issues (like the reports not rendering properly). I figure that this isn't a real cause for concern, since most of these components will likely be rewritten in the next few months based on the new UX.

@mbusch3 mbusch3 linked an issue Jan 24, 2025 that may be closed by this pull request
…ocal and one general. I've renamed the local one "handleSingleIssueSave".
@mbusch3
Copy link
Author

mbusch3 commented Jan 31, 2025

The responsiveness issues are still there. Although things seem to save. I'm still working out that, and the most recent issue is "showExample" is not defined when I go to revisit a previously resolved issue.

@dmols
Copy link
Contributor

dmols commented Feb 5, 2025

Some things to note for future reference:

  • Preview image isn't loading dynamically with any UFIXIT forms where the user should be able to alter values such as HTML text, color contrast, etc.
  • When the Save button in a UFIXIT form is pressed, it doesn't trigger the pending state as quickly as the other branches. It still does it but there's a noticeable few seconds delay. Not sure yet what to attribute both these issues to.

That said, they're not breaking changes and we benefit from adding this to dev already. Merging to the dev-pr-testing branch after adding a CHANGELOG.md entry.

@dmols
Copy link
Contributor

dmols commented Feb 5, 2025

The responsiveness issues are still there. Although things seem to save. I'm still working out that, and the most recent issue is "showExample" is not defined when I go to revisit a previously resolved issue.

Can't seem to recreate this issue but will keep in mind for if the issue shows up on dev.

@dmols
Copy link
Contributor

dmols commented Feb 5, 2025

Some things to note for future reference:

  • Preview image isn't loading dynamically with any UFIXIT forms where the user should be able to alter values such as HTML text, color contrast, etc.
  • When the Save button in a UFIXIT form is pressed, it doesn't trigger the pending state as quickly as the other branches. It still does it but there's a noticeable few seconds delay. Not sure yet what to attribute both these issues to.

That said, they're not breaking changes and we benefit from adding this to dev already. Merging to the dev-pr-testing branch after adding a CHANGELOG.md entry.

On second thought, it would be simpler to just update the CHANGELOG in the merged-to branch. Will make the changes there.

@dmols dmols merged commit 5951e84 into ucfopen:dev-pr-testing Feb 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade the primary components to React 18.3.1
2 participants