fix: Svelte runes detection not working correctly in monorepos #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hmnd
force-pushed
the
fix/svelte-runes-detection
branch
from
85519d9
to
a97ca8c
Compare
|
/cc @benmccann @dominikg |
benmccann
approved these changes
Oct 20, 2024
|
@hmnd @benmccann to release this we also need this another PR #381 and switch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#347 introduced support for Svelte 5 runes. In doing so, the Svelte plugin now imports from
svelte/compiler. Withoutsveltebeing listed as an optional peer dependency, the import did not correctly resolvesveltefrom the current workspace within a monorepo. Thus, if another package in the monorepo depended on Svelte 5, a package depending on Svelte 4 could be misidentified as the newer version.