Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor setup.py: #114

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Refactor setup.py: #114

wants to merge 3 commits into from

Conversation

mindw
Copy link
Contributor

@mindw mindw commented Jun 26, 2015

  • use entry_points
  • build universal wheels
  • use setuptools_scm for version tracking
  • eliminate readme duplication by dropping README.md
  • use manifest.in
  • add .gitignore

For your consideration.

@mmckerns
Copy link
Member

@mindw: thanks, you make some good suggestions. This is a big patch, so I'll have to come back to it when I can fully review it (i.e. soon, but not immediately).

@mindw
Copy link
Contributor Author

mindw commented Jun 26, 2015

Sure.

@mindw
Copy link
Contributor Author

mindw commented Aug 20, 2015

rebased.

@mmckerns
Copy link
Member

thanks for keeping it on the radar.

@kernc
Copy link
Contributor

kernc commented Nov 17, 2016

👍 on this. I envision a hard time advocating this to my team with so horribly unconventional setup script. 😃
Would be happy to help review it when @mindw rebases it yet again.

@mindw
Copy link
Contributor Author

mindw commented Nov 17, 2016

non dead yet :)
rebased.

- tuple, list, dict, file, buffer, builtin,
- both old and new style classes,
- instances of old and new style classes,
- set, frozenset, array, functions, exceptions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This no longer renders as a list but as a code block.


The latest released version of `dill` is available from::

http://trac.mystic.cacr.caltech.edu/project/pathos
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to make these links clickable, probably by dedenting.


You can get the latest development version with all the shiny new features at::

https://github.com/uqfoundation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A URL to dill specifically would be nice.


The latest released version of `dill` is available from::

http://trac.mystic.cacr.caltech.edu/project/pathos
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to make these links clickable, probably by dedenting.

Optional requirements::

- setuptools, version >= 0.6
- objgraph, version >= 1.7.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also consider making these items a list.

Current Release
===============

This version is `dill-%(relver)s`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is relver interpolated somewhere? Additionally, it won't show updated on PyPI which reads raw README.rst.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed line (was never part of the original README).

license = '3-clause BSD',
platforms = ['Linux', 'Windows', 'Mac'],
url = 'http://www.cacr.caltech.edu/~mmckerns/dill.htm',
download_url = 'http://dev.danse.us/packages',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

404 + redundant.

maintainer_email = 'mmckerns at uqfoundation dot org',
license = '3-clause BSD',
platforms = ['Linux', 'Windows', 'Mac'],
url = 'http://www.cacr.caltech.edu/~mmckerns/dill.htm',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer = 'Mike McKerns',
maintainer_email = 'mmckerns at uqfoundation dot org',
license = '3-clause BSD',
platforms = ['Linux', 'Windows', 'Mac'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant.


install_requires = []

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be inlined?

@Peque Peque mentioned this pull request Dec 17, 2016
@mmckerns
Copy link
Member

@kernc: unconventional? FYI, it was a common way to do it at least some years ago, and was standardly used by the likes of numpy and others. However, I agree, it's probably time for an update to something simpler. I'll review this PR and #198 and #191 in the next month, and try to get them resolved.

@mindw & @kernc: there may be some changes that I'm not sure that I want, but several of them I know already should go in. I'm fine with taking a piecemeal approach to this PR as I go through it, if you are.

@mindw
Copy link
Contributor Author

mindw commented Dec 26, 2016

Corrected review comments.

@mmckerns , as you see fit :)

@Peque
Copy link
Contributor

Peque commented Dec 28, 2016

@mindw Maybe you could rebase again... Just to make Travis happy. 😜

* use entry_points
* build universal wheels
* use setuptools_scm for version tracking
* eliminate readme duplication by dropping README.md
* use manifest.in
* add .gitignore
@mindw
Copy link
Contributor Author

mindw commented Dec 29, 2016

rebased.

* remove outdated Python versions (2.5, 3.1, 3.2)
* make sure pip & setuptools are up to date
@shuttle1987
Copy link

Any updates on this?

@mmckerns
Copy link
Member

mmckerns commented Sep 9, 2018

@shuttle1987: no not yet.

@hugovk
Copy link
Contributor

hugovk commented Sep 9, 2018

Good news! Since the new PyPI (aka Warehouse) launched, it's now possible to use Markdown directly as the long_description rather than RST.

See these instructions and example:

@mmckerns mmckerns mentioned this pull request May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants