Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove component protocol constraint #2083

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

Rene2mt
Copy link
Contributor

@Rene2mt Rene2mt commented Nov 26, 2024

Committer Notes

This PR resolves issue #2082 by removing the constraint that is preventing use of protocol assembly on components of any type other than "service".

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated the OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the OSCAL-Pages and OSCAL_Reference repositories.

@Rene2mt Rene2mt requested a review from a team as a code owner November 26, 2024 22:26
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support this change.

@aj-stein-gsa
Copy link
Contributor

Is there any update on NIST's review of this PR? We have a series of challenges pertaining to this model-internal constraint and building effective constraints, and this issue seems to be associated with reports from a number of community members indicating it (originally #1913), so it would be good if we could get NIST review and consider it part of a candidate release.

Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iMichaela iMichaela merged commit e0b87b5 into usnistgov:develop Dec 17, 2024
1 check passed
@aj-stein-gsa
Copy link
Contributor

LGTM

Thank you for the prompt review, it is very much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants