Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not read file level metrics data for landing page #320

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

chuanlin2018
Copy link
Collaborator

Removed the code that read file level metrics which wasn't used in landing page.

@chuanlin2018 chuanlin2018 requested a review from deoyani June 26, 2023 17:10
Copy link
Collaborator

@RayPlante RayPlante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like one of the angular unit tests is failing. Run "npm test" to see details; please update.

@chuanlin2018
Copy link
Collaborator Author

Checking...

@chuanlin2018
Copy link
Collaborator Author

Unit test should be fixed now.

Copy link
Collaborator

@RayPlante RayPlante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests now pass. Behavior was tested on testdata (along with #323).

@RayPlante RayPlante merged commit b902be4 into integration Jan 11, 2024
2 checks passed
@RayPlante RayPlante deleted the metrics-no-ediid branch January 11, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants