Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Bundle Name #354

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Rename Bundle Name #354

merged 2 commits into from
Dec 19, 2024

Conversation

elmiomar
Copy link
Contributor

This PR updates the logic for generating bundle names in the datacart to address Greg's feedback.

New name format: NIST-Data-[timestamp], where timestamp is in a human readable format: YYYY-MM-DDTHH-MM.

Changes:

  1. Updated generateZipFileName Method
  • The new implementation generates a file name based on the current timestamp:
private generateZipFileName(base: string = "NIST-Data"): string {
    const now = new Date();
    const timestamp = now.toISOString().slice(0, 16).replace(":", "-");
    return `${base}-${timestamp}`;
}
  1. Replaced Bundle Name Logic
  • Updated references to use the new method:
let bundleBaseName = this.generateZipFileName("NIST-Data");

Testing:

  • These changes were tested locally using oar-docker to verify that the bundle names align with the new format when downloading bundles from the datacart.

Copy link
Collaborator

@chuanlin2018 chuanlin2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and worked as expected.

@chuanlin2018 chuanlin2018 merged commit 36df4b3 into integration Dec 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants