DENA-671: Update millis in one month and year #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcinGinszt
reviewed
Nov 4, 2024
| - 1 month has 30 days | ||
| - 1 year has 365 days | ||
| - 1 month has `2629800000` millis which is 30.4375 days | ||
| - 1 year has `31556952000` millis which is 365.2425 days |
There was a problem hiding this comment.
maybe it would be also worth to include this information as a comment in msk_topic_config.go?
MarcinGinszt
approved these changes
Nov 4, 2024
|
This is not necessary, as I added rounding to the initial PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting diffs on the current kafka-cluster-config values.
Updated based on what popular converters say and on the criteria that more is better than less.
There are still diffs on the kafka-cluster-config values, but at least we'll unify these