Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blackjack Leaderboards Functionality #531

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Blackjack Leaderboards Functionality #531

wants to merge 9 commits into from

Conversation

sagarpatel211
Copy link

Summary of Changes

  • This ticket addresses the implementation for a Blackjack leaderboards function.

Motivation and Explanation

  • This feature improve the bot as it expands functionality by displaying a Leaderboards for game Blackjack

Related Issues

Steps to Reproduce

  • Run the Discord bot and checkout to leaderboard-helper
  • Call .bjlb t or .bjlb wr in your test channel to try it out

Demonstration of Changes

  • bjlb t to check the Blackjack total coins earned leaderboard
  • .bjlb wr to check the Blackjack winrate leaderboard

Further Information and Comments

  • Let me know if there's any changes I can make or improvements in my code style, documentation, etc.!

@sagarpatel211 sagarpatel211 linked an issue Jul 28, 2024 that may be closed by this pull request
Add blackjack leaderboards #264
Open
@sagarpatel211 sagarpatel211 self-assigned this Jul 28, 2024
@davidgan1218
Copy link
Contributor

  1. Negative Coin Issue on Blackjack
  2. Winrate Leaderboard should be 0% instead of N/A if you have no wins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fan-Yang-284 Fan-Yang-284 Awaiting requested review from Fan-Yang-284

@probro27 probro27 Awaiting requested review from probro27

At least 1 approving review is required to merge this pull request.

Assignees

@sagarpatel211 sagarpatel211

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add blackjack leaderboards
2 participants
@sagarpatel211 @davidgan1218