Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Implement DBSize Server Management Cluster #2995

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Go: Implement DBSize Server Management Cluster #2995

wants to merge 24 commits into from

Conversation

EdricCua
Copy link
Collaborator

Issue link

This Pull Request is linked to issue (URL): #2876

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@EdricCua EdricCua requested a review from a team as a code owner January 23, 2025 03:14
@Yury-Fridlyand Yury-Fridlyand added the go golang wrapper label Jan 23, 2025
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Jan 23, 2025
Open
7 tasks
EdricCua and others added 10 commits January 28, 2025 14:44
@EdricCua
Implement DBSize Server Management Cluster
d0b68b2 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix docs
f8c079b 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix docs
647ace3 
Signed-off-by: EdricCua <[email protected]>
@BoazBD @EdricCua
ORT- Add resolutions for hybrid-node-tests and bump versions (valkey-…
ce21c43 
…io#2987)

* add resolutions for hybrid-node-tests and bump ORT versions

Signed-off-by: BoazBD <[email protected]>

* format

Signed-off-by: BoazBD <[email protected]>

---------

Signed-off-by: BoazBD <[email protected]>
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Go: Implement Server Management Command DBSize (valkey-io#2991)
ce9d639 
* Implement DBSize Command

Signed-off-by: EdricCua <[email protected]>
@EdricCua
GO: Implement Copy Command (valkey-io#2980)
b3d24c4 
* Implement Copy Command

Signed-off-by: EdricCua <[email protected]>
@edlng @EdricCua
Moved documentation comments to base_client file and made changes to …
9a91407 
…GlideClient for pkgsite to work (valkey-io#2981)

* moved docs from interfaces to base client

Signed-off-by: Edward Liang <[email protected]>
Signed-off-by: EdricCua <[email protected]>
@edlng @EdricCua
quickfix of changing glideClient to become GlideClient (valkey-io#3000)
3dba55c 
Signed-off-by: Edward Liang <[email protected]>
Signed-off-by: EdricCua <[email protected]>
@tjzhang-BQ @EdricCua
Go: Add command XRange and XRevRange (valkey-io#2989)
30c7d4e 
* Go: Add command XRange and XRevRange

Signed-off-by: TJ Zhang <[email protected]>
Signed-off-by: EdricCua <[email protected]>
@niharikabhavaraju @EdricCua
Go: Added config folder for request_routing_config_test.go and errors…
9511625 
… folder for errors.go (valkey-io#2996)

* Implemented Time Command

Signed-off-by: Niharika Bhavaraju <[email protected]>

* Fixed code review changes

Signed-off-by: Niharika Bhavaraju <[email protected]>

* Added Time command (cluster)

Signed-off-by: Niharika Bhavaraju <[email protected]>

* Fixed code review comments

Signed-off-by: Niharika Bhavaraju <[email protected]>

* Added route,errors folders

Signed-off-by: Niharika Bhavaraju <[email protected]>

* Fixed failing tests

Signed-off-by: Niharika Bhavaraju <[email protected]>

---------

Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: EdricCua <[email protected]>
@EdricCua EdricCua force-pushed the Go-DBSize-ServerManagementCluster branch from a8d627e to 9511625 Compare January 28, 2025 14:44
EdricCua added 10 commits January 28, 2025 14:45
@EdricCua
Merge remote-tracking branch 'origin' into Go-DBSize-ServerManagement…
d2e2dd7 
…Cluster

"Signed-off-by: EdricCua <[email protected]>"
@EdricCua
Merge remote-tracking branch 'origin' into Go-DBSize-ServerManagement…
5c19e0a 
…Cluster

"Signed-off-by: EdricCua <[email protected]>"
@EdricCua
Implement DBSize Cluster
329c906 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Implement DBSize Cluster
b5c1f36 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Implement DBSize Cluster
4978dff 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Implement DBSize Cluster
30ed5a2 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Implement DBSize Cluster
277d12c 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Implement DBSize Cluster
724f071 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Implement DBSize Cluster
60fd222 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Merge remote-tracking branch 'origin' into Go-DBSize-ServerManagement…
0507f01 
…Cluster

"Signed-off-by: EdricCua <[email protected]>"
Yury-Fridlyand
Yury-Fridlyand reviewed Jan 28, 2025
View reviewed changes
go/api/glide_cluster_client.go Outdated Show resolved Hide resolved
go/api/glide_cluster_client.go Outdated Show resolved Hide resolved
go/api/options/route_options.go Show resolved Hide resolved
@EdricCua
Fix merge conflict
5bd1d69 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix merge conflict
8c5fed7 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix review comment
695cd77 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix docs for RouteOption
ec183a4 
Signed-off-by: EdricCua <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateek-kumar-improving prateek-kumar-improving prateek-kumar-improving approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

Assignees
No one assigned
Labels
go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@EdricCua @Yury-Fridlyand @prateek-kumar-improving @BoazBD @edlng @tjzhang-BQ @niharikabhavaraju