feat(url): Add valkey and valkeys schemes #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added tests |
rueian
reviewed
Dec 29, 2024
url_test.go
Outdated
| @@ -15,12 +15,18 @@ func TestParseURL(t *testing.T) { | |||
| if opt, err := ParseURL("rediss://"); err != nil || opt.TLSConfig == nil { | |||
| t.Fatalf("unexpected %v %v", opt, err) | |||
| } | |||
| if opt, err := ParseURL("valkeyss://"); err != nil || opt.TLSConfig == nil { | |||
There was a problem hiding this comment.
You are right! It's fixed. Thanks.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
=======================================
Coverage 94.68% 94.68%
=======================================
Files 92 92
Lines 39096 39096
=======================================
Hits 37019 37019
Misses 1763 1763
Partials 314 314 ☔ View full report in Codecov by Sentry. |
Inspired by the valkey-py client. https://github.com/valkey-io/valkey-py/blob/v6.0.2/valkey/_parsers/url_parser.py#L40 Signed-off-by: Julien Riou <[email protected]>
|
I've also removed the test on the init address for the valkey scheme because the goal on this line is to test the scheme, not the init address that is already covered by other tests. And added the plural form in the commit title ("Add valkey and valkeys schem schemes"). |
jouir
changed the title
rueian
pushed a commit
that referenced
this pull request
Dec 29, 2024
Inspired by the valkey-py client. https://github.com/valkey-io/valkey-py/blob/v6.0.2/valkey/_parsers/url_parser.py#L40 Signed-off-by: Julien Riou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the valkey-py client.
https://github.com/valkey-io/valkey-py/blob/v6.0.2/valkey/_parsers/url_parser.py#L40