fix #25: Add IFEQ option to SET command
#27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueian
reviewed
Jan 23, 2025
hack/cmds/commands.json
Outdated
Comment on lines
5065
to
5069
| { | ||
| "type": "block", | ||
| "arguments": [ | ||
| { | ||
| "name": "ifeq", | ||
| "type": "pure-token", | ||
| "token": "IFEQ" | ||
| }, | ||
| { | ||
| "name": "comparison-value", | ||
| "type": "string" | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
Hi @px86, there is no need to use the block type, just merge the current ifeq and comparison-value into one string type argument.
|
Hi @px86, the DCO action failed. I think you need to use |
|
Hi @px86, you need to -s (sign off) for every commit. Your first commit is not signed off, or you can merge your two commits into one signed off commit. |
Signed-off-by: Pushkar Raj <[email protected]>
Signed-off-by: Pushkar Raj <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
- Coverage 94.54% 94.54% -0.01%
==========================================
Files 95 95
Lines 39315 39351 +36
==========================================
+ Hits 37170 37204 +34
- Misses 1817 1818 +1
- Partials 328 329 +1 ☔ View full report in Codecov by Sentry. |
|
Thank you so much @px86! |
rueian
pushed a commit
that referenced
this pull request
Jan 24, 2025
* fix #25: Add `IFEQ` option to `SET` command Signed-off-by: Pushkar Raj <[email protected]> * Removed `block` argument per PR comment Signed-off-by: Pushkar Raj <[email protected]> --------- Signed-off-by: Pushkar Raj <[email protected]> Signed-off-by: Rueian <[email protected]>
rueian
pushed a commit
that referenced
this pull request
Jan 24, 2025
* fix #25: Add `IFEQ` option to `SET` command Signed-off-by: Pushkar Raj <[email protected]> * Removed `block` argument per PR comment Signed-off-by: Pushkar Raj <[email protected]> --------- Signed-off-by: Pushkar Raj <[email protected]> Signed-off-by: Rueian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.