Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: add contributor ack for valkey-go #29

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

SoulPancake
Copy link
Contributor

Mirroring the same contributor acknowledgement for valkey-go repository.

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (9b154d3) to head (6b30c6b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   94.55%   94.54%   -0.01%     
==========================================
  Files          95       95              
  Lines       39394    39394              
==========================================
- Hits        37250    37247       -3     
- Misses       1817     1818       +1     
- Partials      327      329       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SoulPancake SoulPancake force-pushed the ab/contributor-ack-valkey-go branch from df2943a to 1dad635 Compare January 29, 2025 03:05
README.md Show resolved Hide resolved
Co-authored-by: Rueian <[email protected]>
Signed-off-by: Anurag Bandyopadhyay <[email protected]>
@SoulPancake
Copy link
Contributor Author

addressed @rueian

@rueian rueian merged commit 25f0739 into valkey-io:main Jan 29, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants