Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the support for implementing remote debuggers in scripting engines modules.
The module API is extended with scripting engines callbacks and new functions that can be used by scripting engine modules to implement a remote debugger.
Most of the code that was used to implement the Lua debugger, was refactored and moved to the
scripting_engine.c
file, and only the code specific to the Lua engine, remained in thedebug_lua.c
file.The
SCRIPT DEBUG (YES|NO|SYNC)
command was extend with an optional parameter that can be used to specify the engine name, where we want to enable the debugger. If no engine name is specified, the Lua engine is used to keep backwards compatibility.In src/valkeymodule.h we see the module API changes. And in the
helloscripting.c
file we can see how to implement a simple debugger for the dummy HELLO scripting engine.