Modify parameter of clientMatchesFilter function. #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1733 +/- ##
============================================
- Coverage 71.17% 70.95% -0.22%
============================================
Files 123 123
Lines 65536 65536
============================================
- Hits 46645 46503 -142
- Misses 18891 19033 +142
|
Signed-off-by: Ray Cao <[email protected]>
RayaCoo
force-pushed
the
clientFilter-param-pointer
branch
from
bda5d3c to
6634a15
Compare
soloestoy
approved these changes
Feb 14, 2025
zuiderkwast
approved these changes
Feb 14, 2025
sarthakaggarwal97
approved these changes
Feb 14, 2025
enjoy-binbin
approved these changes
Feb 15, 2025
zuiderkwast
pushed a commit
that referenced
this pull request
Feb 15, 2025
small change to [#1401](#1401). pass `clientFilter *` to clientMatchesFilter as suggest in [comment](6bc64ca#r1875844273). Signed-off-by: Ray Cao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small change to #1401.
pass
clientFilter *to clientMatchesFilter as @zuiderkwast suggest in comment.