-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a daily test running for ARM #1738
base: unstable
Are you sure you want to change the base?
Conversation
Signed-off-by: Madelyn Olson <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1738 +/- ##
============================================
+ Coverage 71.02% 71.08% +0.05%
============================================
Files 121 123 +2
Lines 65176 65536 +360
============================================
+ Hits 46290 46585 +295
- Misses 18886 18951 +65 |
Signed-off-by: Madelyn Olson <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is so good, we can use these runners for binary build as well as we were seeing issues on that front |
format-yaml seems to be failing, @madolson could you take a look ? |
Signed-off-by: Madelyn Olson <[email protected]>
Github now has official arm github runners, so we can now more officially verify the ARM build.
EDIT: I also modified the list of notify jobs, since it caused a merge conflict which was really hard to manually verify, so moved to a more natural yaml list format.