Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a daily test running for ARM #1738

Open
wants to merge 5 commits into
base: unstable
Choose a base branch
from

Conversation

madolson
Copy link
Member

@madolson madolson commented Feb 14, 2025

Github now has official arm github runners, so we can now more officially verify the ARM build.

EDIT: I also modified the list of notify jobs, since it caused a merge conflict which was really hard to manually verify, so moved to a more natural yaml list format.

@madolson madolson added the run-extra-tests Run extra tests on this PR (Runs all tests from daily except valgrind and RESP) label Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.08%. Comparing base (78bcc0a) to head (4fecbd2).
Report is 42 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1738      +/-   ##
============================================
+ Coverage     71.02%   71.08%   +0.05%     
============================================
  Files           121      123       +2     
  Lines         65176    65536     +360     
============================================
+ Hits          46290    46585     +295     
- Misses        18886    18951      +65     

see 45 files with indirect coverage changes

@madolson madolson requested a review from hpatro February 14, 2025 19:00
.github/workflows/daily.yml Outdated Show resolved Hide resolved
.github/workflows/daily.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@hpatro hpatro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roshkhatri
Copy link
Member

This is so good, we can use these runners for binary build as well as we were seeing issues on that front

@hpatro
Copy link
Collaborator

hpatro commented Feb 14, 2025

format-yaml

format-yaml seems to be failing, @madolson could you take a look ?

.github/workflows/daily.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-extra-tests Run extra tests on this PR (Runs all tests from daily except valgrind and RESP)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants