Partial WebExtension update for 115. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this stage this is still a prove-of-concept and I have not finished the update completely. This PR removes the BootstrapLoader API and all of your legacy code and recreates the functionality using WebExtension APIs.
If you think this is a working solution, we can move it forward to be a pure WebExtension without any Experiments soon.
The options have to be moved to your dedicated add-on options page, which is a smal html file which will loaded when the user clicks on the wrench icon in the add-on manager. This PR does not include an options page and you need to open about:config to manually change our options.
The PR includes the LegacyPrefs API to continue to access your old prefs. The prefs need to be migrated to WebExtension local storage and after some time the API can be removed.
The PR uses the ScrollToView API, which is needed to fix a bug in TB, which will be resolved soon and then this API can be removed as well.
I do not know what the focus preference was for, it is not used by this PR.
What do you think? I would be available for help on the remaining steps, of course.