-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial draft of JOSS paper #394
Conversation
@stsievert are you interested in being an author on this JOSS paper with @jakevdp and I? We want to be generous with authorship and you have definitely contributed. If there is anyone else who wants to be an author, please let us know as well. The criteria for authorship is a contribution to Altair and a willingness to review the paper and certify that you have reviewed its content and approve of it. |
@ellisonbg I'd be happy to be an author! And 👍 for publishing – altair is quality software. My orcid is 0000-0002-4275-3452 and I'm affiliated with University of Wisconsin--Madison. I have read the submission and approve the content. |
@stsievert great! Also wanted to clarify for others. The criteria of authorship is "contribution" - but that doesn't necessarily have to be code/PR/commits. It could also be design, documentation, discussion, etc. Would love to have any others join who have contributed in these ways. |
Sure!
…On Mon, Oct 16, 2017 at 9:08 PM, Dominik Moritz ***@***.***> wrote:
Can you add the VL folks who helped with Altair?
- name: Dominik Moritz
orcid: 0000-0002-3110-1053
affiliation: 1
@kanitw <https://github.com/kanitw> @jheer <https://github.com/jheer>,
what are your orcids?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#394 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABr0DhkFFLN6cx57f6dj-PmcTDWWsomks5stChXgaJpZM4PqJjT>
.
--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
[email protected] and [email protected]
|
I have enjoyed creating examples and testing the 2.0 api. I would love to be an author if you think that's appropriate. I have read the submission and approve of its content. My information is
|
Finally got an Orc ID. Here you go.
|
Here's my info, reformatted.
|
Here is mine!
|
Hi everyone, with Altair 2.0 release, I think it would be a good time to finish the JOSS paper. I have rebased on master, and added everyones names, orcid IDs and affiliations that commented above. A few questions:
|
I think @palewire should be included, if he is interested. |
I think it makes sense to include the top contributors from https://github.com/altair-viz/altair/graphs/contributors. I'm not sure how liberal you want to be with authorship but there probably needs to be some cutoff (e.g. code patches for bugs or features, two non-trivial examples, advising role, ...) so that the list doesn't become too long (and soon outdated). |
I also suggest @iliatimofeev for his work on bringing geopandas to altair: #818 |
If you'll have me, I'm happy to join.
What else can the proposal use? I see a number of things that could a reference or hyperlink. Is there a preferred formatting style for that? If nothing else, a little copy editing? |
@palewire yes, happy to have you! I just pushed a commit with the affiliation fixes and your information |
I made some updates and sent a PR: ellisonbg#4. What else is left? |
Thanks! I am traveling until Th - will have a look when I get home.
Would be good to get this finished.
…On Tue, Aug 7, 2018 at 9:50 PM Dominik Moritz ***@***.***> wrote:
I made some updates and sent a PR: ellisonbg#4. What else is left?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
[email protected] and [email protected]
|
If it still possible I'll be happy to be mentioned
|
@iliatimofeev, I added you to ellisonbg#4. |
paper/paper.md
Outdated
|
||
The declarative nature of the Vega-Lite visualization grammar, and its encoding in a formal | ||
JSON schema, provide Altair with a number of benefits. First, much of the Altair Python code, | ||
tests, and examples are autogenerated from the Vega-Lite JSON schema, ensuring strict conformance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove "examples" here, because we no longer auto-generate them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in ellisonbg@6e995d0
I made a pass to finish the paper. Check out ellisonbg#5 and let me know if you have any feedback. |
Who wants to take care of the submission? Is there something else left to do? |
I have opened ellisonbg#6, which has a WIP label (tentative implementation, and open for discussion). |
Ups, that looks like myistake. Yes, we should credit you as a contributor as per @ellisonbg'e comment. |
Thanks for the comment @domoritz. I've removed the WIP in label from that PR. |
I haven't done a JOSS submission before, but as I understand it, we should
be ready to go. Can someone else handle the submission?
…On Mon, Oct 8, 2018 at 8:40 AM Dominik Moritz ***@***.***> wrote:
Who wants to take care of the submission? Is there something else left to
do?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#394 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABr0LvNu5T2clKbB9cJbt9Ywk4Zc8dwks5ui3HagaJpZM4PqJjT>
.
--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
[email protected] and [email protected]
|
Can you merge ellisonbg#6? |
Revert deletion from author list
@ellisonbg Thanks! @jakevdp @ellisonbg I'm happy to prepare the submission when you squash/merge this PR. The paper has to be in the repo. |
ping @jakevdp @ellisonbg |
I am going to merge, we can always make minor changes later. I don't remember who the person was willing to review the JOSS article, but they were an editor, so they should see it upon submission. Thanks everyone! |
Thanks. I'll get the submission started. |
You can follow the progress at https://joss.theoj.org/papers/cd11f880b3f81bf5b5a225007212dc8b |
Here is the review issue openjournals/joss-reviews#1024 |
Hi all, here is a draft of a JOSS paper. I would like to submit this to JOSS after the 1.2.1 release comes out. Right now I have listed Jake and I as authors, but if there is anyone else who has contributed that wants to be listed, please post to this issue:
I am still working on getting all the references in place. Also would love ideas for an example image to include.
Fixes #389