Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse max-age in set cookie #995

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sibiraj-s
Copy link

Fixes #941

Copy link

changeset-bot bot commented Oct 12, 2024

🦋 Changeset detected

Latest commit: 0e3c559

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@edge-runtime/cookies Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 12, 2024

@sibiraj-s is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@Kikobeats
Copy link
Member

Hello, in order to merge this PR, it needs a unit test

@sibiraj-s
Copy link
Author

Hello, in order to merge this PR, it needs a unit test

@Kikobeats added unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cookie: parseSetCookie ignores Max-Age attribute
2 participants