Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vercel/otel] update install step #132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

[vercel/otel] update install step #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/otel/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
## 📦 Installation

```sh
npm install @vercel/otel
npm install @vercel/otel @opentelemetry/api @opentelemetry/api-logs @opentelemetry/instrumentation @opentelemetry/resources @opentelemetry/sdk-logs @opentelemetry/sdk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these needed? IIUC:

  • @opentelemetry/api and @opentelemetry/api-logs get in as peer deps
  • @opentelemetry/instrumentation and @opentelemetry/sdk/sdk-logs shouldn't be needed at all.
  • @opentelemetry/resources - I don't think this one is needed either

Copy link
Collaborator Author

@kakadiadarpan kakadiadarpan Nov 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dvoytenko The dependencies I added here are listed as peerDependencies listed in the package.json

When using pnpm to install @vercel/otel, they are missing from node_modules (check the screenshot below)
CleanShot 2024-11-14 at 16 33 33@2x

```

## 📚 Usage
Expand Down
Loading