Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deprecate personal Vercel id for team id #43

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: deprecate personal Vercel id for team id #43

wants to merge 1 commit into from
+55 −39

Conversation

phidol
Copy link
Contributor

@phidol phidol commented Nov 10, 2024

See #28

@phidol phidol mentioned this pull request Nov 10, 2024
Open
@phidol phidol force-pushed the feat/deprecate-personal-id-for-team-id branch 2 times, most recently from b30e060 to 26e0ff6 Compare November 14, 2024 07:28
paulogdm
paulogdm previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@paulogdm paulogdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good by the code, but can we test this?
Also, double check task.json values.

@phidol phidol force-pushed the feat/deprecate-personal-id-for-team-id branch from 26e0ff6 to 7dd8175 Compare February 8, 2025 11:49
@phidol phidol force-pushed the feat/deprecate-personal-id-for-team-id branch from 7dd8175 to 41e1285 Compare February 8, 2025 11:52
@phidol phidol requested a review from paulogdm February 8, 2025 11:54
@phidol
Copy link
Contributor Author

phidol commented Feb 8, 2025

Hey @paulogdm,
I've rebased the PR and adjusted a spot I've missed. Unfortunately the change needs to be merged to create a preview.
I can setup an example of a 'dysfunctional' config as well as the already documented proper configuration in a public Azure project of mine as soon as there's a preview version available to verify the changes!

@paulogdm
Copy link
Member

@phidol done!

@phidol
Copy link
Contributor Author

phidol commented Feb 11, 2025

Hey @paulogdm,
I'm neither allowed to merge the changes nor to run the pipeline for the creation of the preview version.
Could you please do so?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulogdm paulogdm paulogdm approved these changes

@TooTallNate TooTallNate Awaiting requested review from TooTallNate TooTallNate is a code owner

@jeffsee55 jeffsee55 Awaiting requested review from jeffsee55 jeffsee55 is a code owner

@codybrouwers codybrouwers Awaiting requested review from codybrouwers codybrouwers is a code owner

@Zertsov Zertsov Awaiting requested review from Zertsov Zertsov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phidol @paulogdm