Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX On Tablets And Touchscreen Laptops #111

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

SamarthMP
Copy link

This PR adds better support for tablets, because currently some things don't work very well.

  1. The mobile warning message will now only show if the window aspect ratio is vertical, which allows tablets access but not phones.
  2. The wording of the mobile warning message is slightly different to show that it can be accessed on tablets as well.
  3. You can now play a song by tapping on it instead of double tapping, which is a better touch experience. On desktop, you still have to double click. This change also affects touchscreen laptops.
  4. Tooltips have been disabled on tablets, to prevent them from popping up for a split second when buttons are tapped.

I have tested these changes on a Samsung Galaxy Tab S9+ and an iPad simulator.
There are still some bugs to be ironed out on touchscreens, but this is a start.

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aonsoku ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 11:30am

@victoralvesf
Copy link
Owner

victoralvesf commented Jan 9, 2025

Could you include the same function to deal with the touch event, on the component data-table-list.tsx aswell? This other component is almost the same as the data-table.tsx, but is for infinite scroll, used in songs page and queue.

The part where the click/touch event is called, is inside data-table-list-row.tsx component.

@SamarthMP
Copy link
Author

Sorry for late response, I'm kinda busy this week so I'll try next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants