Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFWD Feedback / Updates #151

Merged
merged 15 commits into from
Oct 7, 2024
Merged

CFWD Feedback / Updates #151

merged 15 commits into from
Oct 7, 2024

Conversation

bd-viget
Copy link
Contributor

Summary

This PR incorporates some of the discoveries found in the CFWD Project. In summary:

  • Notes/Comments/Instructions
  • Navigation Container Editor Styles
  • Post Excerpt Block Support in ACF Blocks Toolkit
  • Fixes Duplicate Admin Notice
  • Formats theme.json file
  • Automates colors for WordPress
  • Adds WP Columns and Mobile Menu Breakpoints
  • Moves some of the dev files into src folder.
  • Updates ACF to latest version
  • Updates NPM Packages to latest
  • Restores CTA and Image/Text Patterns
  • Adds Default templates for Post Archive and Singular

Issues

Testing Instructions

N/A

Screenshots

N/A

@bd-viget bd-viget self-assigned this Sep 30, 2024
Copy link
Contributor

@nathan-schmidt-viget nathan-schmidt-viget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Some really nice update.
One thought with the minifying theme.json if you have a different view, let me know.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you updated this as well!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang this is cool! Did you build this from scratch or find a demo?!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly Stack Overflow 🤣

@@ -1,4 +1,4 @@
//Move any block that you are working to a new file to make it easyer to maintain
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 good catch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I was minifying this is because it saves some file size but more importantly it made it hard to edit the file directly, as any edit should be done in the JS file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think we just need to make sure that's clear from the README/Documentation side, however, I think there are a few good reasons to have it formatted:

  • Once the project is handed off, the client may not have the ability to use the build tools, or understand how to manage this file with the provided JS parts.
  • Debugging can be difficult, and this makes it easier to determine if styles are coming from theme.json or somewhere else (in a CSS file). It can also be useful to confirm settings are stored as they are expected to be.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point with the client having the option to edit it post hand off. I like it!

@bd-viget bd-viget merged commit 1eed3c0 into main Oct 7, 2024
@bd-viget bd-viget deleted the bd/cfwd-feedback branch October 7, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants