Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-vue): deprecate inline main (fix #31) #222

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aweikalee
Copy link

@aweikalee aweikalee commented Aug 6, 2023

Description

vite-plugin-vue should deprecate inline main, because .vue file can't be processed as js/ts.

fix: #31, vite#13756

Additional context

When using vite dev, lang="js" or lang="ts" will be skip build,

Live demo: stackblitz

lang="js" or lang="ts" will as inline main, skip js/ts build. Because its extname is .vue.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@alamhubb
Copy link

#444 I am also trying to solve this problem. Why has this PR not been accepted for so long?

@alamhubb alamhubb mentioned this pull request Sep 15, 2024
6 tasks
@edison1105
Copy link
Member

Closing as #31 has been fixed via #444

@aweikalee
Copy link
Author

关闭#31 的问题已通过#444修复

The problem is not completely solved.

#444 only fixed lang="ts", the problem still exists with lang="js".

@sxzz
Copy link
Member

sxzz commented Sep 18, 2024

@edison1105 We should have an option to disable inline main. Some Vite plugin only transforms .ts files but not Vue files.

@edison1105 edison1105 reopened this Sep 18, 2024
@aweikalee
Copy link
Author

I think inline main should be deprecated or default to false.
Inline main makes compilation lose consistency.
The same code will compile to different results in lang="js", lang="ts", lang="jsx/tsx".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev server does not transpile script in .vue files (but it works in .ts ones)
4 participants