-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Errant GTID detection logic in SetReplicationSource
#17031
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic in this PR looks good. I think we can go even stricter, see inline comment.
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17031 +/- ##
==========================================
- Coverage 67.15% 67.14% -0.01%
==========================================
Files 1571 1571
Lines 251846 251869 +23
==========================================
- Hits 169137 169130 -7
- Misses 82709 82739 +30 ☔ View full report in Codecov by Sentry. |
…are merged in release-21.0 Signed-off-by: Manan Gupta <[email protected]>
Description
This PR fixes the problem described in #17018.
Now that we're aware that the primary tablet can advertise itself as behind a replica tablet, we have fixed the errant gtid detection in
SetReplicationSource
. To do this, we have made the following changes -PrimaryStatus
RPC to also send the server UUID.PrimaryStatus
instead ofPrimaryPosition
inSetReplicationSource
code, and use the Server UUID to discount the writes coming from the primary tablet.The RPC changes made to
PrimaryStatus
will also be backported to release-21.0 before GA release.Related Issue(s)
Checklist
Deployment Notes