Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Errant GTID detection logic in SetReplicationSource #17031

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

GuptaManan100
Copy link
Member

Description

This PR fixes the problem described in #17018.
Now that we're aware that the primary tablet can advertise itself as behind a replica tablet, we have fixed the errant gtid detection in SetReplicationSource. To do this, we have made the following changes -

  1. Augmented PrimaryStatus RPC to also send the server UUID.
  2. We use PrimaryStatus instead of PrimaryPosition in SetReplicationSource code, and use the Server UUID to discount the writes coming from the primary tablet.

The RPC changes made to PrimaryStatus will also be backported to release-21.0 before GA release.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Oct 22, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 22, 2024
@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Oct 22, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Oct 22, 2024
@GuptaManan100 GuptaManan100 marked this pull request as ready for review October 22, 2024 07:21
go/vt/vttablet/tabletmanager/tm_init.go Outdated Show resolved Hide resolved
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic in this PR looks good. I think we can go even stricter, see inline comment.

go/mysql/replication/mysql56_gtid_set.go Show resolved Hide resolved
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 44.23077% with 29 lines in your changes missing coverage. Please review.

Project coverage is 67.14%. Comparing base (ba129c7) to head (ad14d41).

Files with missing lines Patch % Lines
go/vt/vttablet/tabletmanager/rpc_replication.go 0.00% 17 Missing ⚠️
go/vt/vttablet/tabletmanager/tm_init.go 57.89% 8 Missing ⚠️
go/vt/mysqlctl/fakemysqldaemon.go 50.00% 2 Missing ⚠️
go/vt/mysqlctl/replication.go 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17031      +/-   ##
==========================================
- Coverage   67.15%   67.14%   -0.01%     
==========================================
  Files        1571     1571              
  Lines      251846   251869      +23     
==========================================
- Hits       169137   169130       -7     
- Misses      82709    82739      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuptaManan100 GuptaManan100 marked this pull request as draft October 22, 2024 10:47
…are merged in release-21.0

Signed-off-by: Manan Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Incorrect errant GTID detection because of how semi-sync replication works
3 participants