Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V1] V1 engine implements parallel sampling (AsyncLLM and LLMEngine) #10980
base: main
Are you sure you want to change the base?
[V1] V1 engine implements parallel sampling (AsyncLLM and LLMEngine) #10980
Changes from 20 commits
57f3329
50584f6
bf3cfd0
98726ed
cd649df
fdc3296
a5415ef
eb9042a
a6637a9
8808c7c
af11e41
07f0c17
522d34c
2e828a8
374f1c7
35036ea
b45c413
00bb1f2
b16ba2b
fbcd213
a4ded40
9752657
119a77c
a64e3b3
36cd555
1f32836
39d3d0b
5462e83
c0f8fb1
252e2ae
97feb43
103ceb6
e6a1134
625e161
e28388e
1c18dc2
c9c3dbb
d927a4a
0f0075c
e4a0e6c
bcdec42
196fc68
f86708a
7e653f9
6b1be36
081a695
a3c5b22
13f3424
5f57964
933a90e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering whether it might be cleaner to also move this method into
ParallelSamplingRequestManager, but it takes the base
generate` method as an additional arg.