Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] Added Google T5 model support to vLLM #11780

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bmullick-amd
Copy link

@bmullick-amd bmullick-amd commented Jan 6, 2025

This PR adds t5 model integration scripts to add support for this model in vLLM repository.
I have tested the results locally both in Nvidia H100 gpus as well as MI300X GPUs using rocm/vllm repository.

Signed-off-by: Baishali <[email protected]>
Copy link

github-actions bot commented Jan 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337
Copy link
Member

DarkLight1337 commented Jan 7, 2025

Thanks for implementing this!

cc @afeldman-nm

It looks like this implementation doesn't use the custom attention bias (relative_attention_bias), as described in #7366 (comment). Do you have plans to add support in this PR or future PRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants