Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Llama model usage in tests #13094

Merged
merged 8 commits into from
Feb 14, 2025

Conversation

hmellor
Copy link
Collaborator

@hmellor hmellor commented Feb 11, 2025

Use meta-llama/Llama-3.2-1B-Instruct for as many models as possible which used larger/older/base variations of Llama.

N.B.

  • LoRA tests could not have their models updated due to having adapters dependent on Llama 2
  • Tool use needed the 3B model
  • Spec decoding tests need a compatible draft and the current meta-llama/Llama-2-7b-chat-hf + JackFram/llama-68m is faster than Llama 3.2 3B + 1B
  • It's worth noting that neuralmagic/Meta-Llama-3-8B-Instruct-FP8 (old) has static per-tensor activations while neuralmagic/Llama-3.2-1B-Instruct-FP8-dynamic (new) is dynamic per token. Therefore, what we're testing in this test has changed slightly

Use `meta-llama/Llama-3.2-1B-Instruct` for as many models as possible which used larger/older variations of Llama.

Signed-off-by: Harry Mellor <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@hmellor hmellor added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 11, 2025
tests/compile/utils.py Outdated Show resolved Hide resolved
tests/lora/conftest.py Outdated Show resolved Hide resolved
tests/lora/test_llama_tp.py Outdated Show resolved Hide resolved
tests/lora/test_ultravox.py Outdated Show resolved Hide resolved
tests/quantization/test_cpu_offload.py Outdated Show resolved Hide resolved
tests/tool_use/utils.py Outdated Show resolved Hide resolved
Signed-off-by: Harry Mellor <[email protected]>
Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going through this!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 14, 2025 06:16
@DarkLight1337
Copy link
Member

There are persistent speculative decoding failures but they are not related to this PR. Merging.

@simon-mo simon-mo merged commit f2b20fe into vllm-project:main Feb 14, 2025
34 of 43 checks passed
@hmellor hmellor deleted the consolidate-test-llamas branch February 14, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force-merge ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants