Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] deepseek_r1_reasoning_parser put reason content in wrong field in certain edge case #13097

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LikeSundayLikeRain
Copy link

@LikeSundayLikeRain LikeSundayLikeRain commented Feb 11, 2025

There's an edge case where close think token is not generated in output due to length limit, in such case, current reasoning parse put the partial reasoning token in content.

Given the model alway generate reasoning tokens(new chat template always append a open think tag), when no close tag detected, we should put in reasoning_content.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the frontend label Feb 11, 2025
@LikeSundayLikeRain LikeSundayLikeRain force-pushed the main branch 3 times, most recently from 40e3fad to c64ab0f Compare February 11, 2025 16:27
…ld when no end think tag in output

Signed-off-by: Mo Xu <[email protected]>
@ywang96
Copy link
Member

ywang96 commented Feb 11, 2025

@gaocegege FYI

@gaocegege
Copy link
Contributor

It's reasonable for the new chat template. LGTM!

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 11, 2025
@gaocegege
Copy link
Contributor

gaocegege commented Feb 12, 2025

There is an error in entrypoint test:

FAILED entrypoints/openai/test_run_batch.py::test_score - AssertionError: proc=<Popen: returncode: 1 args: ['/usr/bin/python3', '-m', 'vllm.entrypoints.ope...>
[2025-02-12T00:52:41Z] assert 1 == 0
[2025-02-12T00:52:41Z]  +  where 1 = <Popen: returncode: 1 args: ['/usr/bin/python3', '-m', 'vllm.entrypoints.ope...>.returncode
[2025-02-12T00:52:41Z] ====== 1 failed, 361 passed, 1 skipped, 34 warnings in 3300.97s (0:55:00) ======

Not sure why it happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants