Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Do not crash V0 engine on input errors #13101

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

joerunde
Copy link
Collaborator

@joerunde joerunde commented Feb 11, 2025

This PR adds exception handling to the V0 engine that catches errors processing the input for a sequence group, and removes that sequence group from the current batch instead of crashing the entire engine. We see this a lot when processing invalid image data for multimodal models, the mllama models are particularly bad offenders.

With this change, users will receive a 400 instead of a 500 when their request fails input processing in the engine, and other running requests will continue to process instead of also receiving 500s.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

vllm/engine/llm_engine.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant