Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Addreses #3935 and #3683, by making intial_incremental_detokenization_offset configurable #13106

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sinamoeini
Copy link

@sinamoeini sinamoeini commented Feb 11, 2025

In this PR makes INITIAL_INCREMENTAL_DETOKENIZATION_OFFSET (which had a default value of 5), configurable. This is particularly useful for sentencepiece based tokenizers. For example by setting

intial_incremental_detokenization_offset = 0

Mistral chat API will work as expected

FIX #3935 #3683

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link

mergify bot commented Feb 12, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @sinamoeini.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

…remental_detokenization_offset configurable

Signed-off-by: Sina Moeini <[email protected]>
@sinamoeini sinamoeini reopened this Feb 12, 2025
@sinamoeini
Copy link
Author

Can I get a review on this thanks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: leading space within content via OpenAI Compatible Server
1 participant