Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further reduce the HTTP calls to huggingface.co #13107

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Further reduce the HTTP calls to huggingface.co #13107

wants to merge 2 commits into from
+79 −56

Conversation

maxdebayser
Copy link
Contributor

@maxdebayser maxdebayser commented Feb 11, 2025 •
edited by github-actions bot
Loading

  • Implement file_exist using list_repo_files
  • Add retry logic to list_repo_files
  • Cache results of list_repo_files

cc: @khluu

@maxdebayser
Further reduce the HTTP calls to huggingface.co
aaeb980 
- Implement file_exist using list_repo_files
- Add retry logic to list_repo_files
- Cache results of list_repo_files

Signed-off-by: Max de Bayser <[email protected]>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@maxdebayser
fix mypy complaint
1c4b8b9 
Signed-off-by: Max de Bayser <[email protected]>
khluu
khluu approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@khluu khluu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general! Thanks for the improvement!

@khluu khluu added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khluu khluu khluu approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxdebayser @khluu