Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix][AMD] Update torch_bindings so that scaled_fp4_quant isn't build on ROCm #13235

Merged
merged 3 commits into from
Feb 15, 2025

Conversation

SageMoore
Copy link
Contributor

@SageMoore SageMoore commented Feb 13, 2025

This should hopefully get the AMD CI green

Signed-off-by: Sage Moore <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link

@shajrawi shajrawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, are there no changes needed in the cmake file?

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 13, 2025
@mgoin mgoin changed the title Update torch_bindings so that scaled_fp4_quant isn't build on ROCm [Bugfix][AMD] Update torch_bindings so that scaled_fp4_quant isn't build on ROCm Feb 13, 2025
@mgoin mgoin added the AMD GPU label Feb 13, 2025
@SageMoore
Copy link
Contributor Author

LGTM, are there no changes needed in the cmake file?

Doesn't look like it. #12784 seems to have done a good job making sure the kernel only gets built on the correct cuda version.

@DarkLight1337
Copy link
Member

Please fix the merge conflicts

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 14, 2025 15:28
@simon-mo simon-mo merged commit c9f9d5b into vllm-project:main Feb 15, 2025
50 of 58 checks passed
Sakalya pushed a commit to Sakalya/vllm that referenced this pull request Feb 15, 2025
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AMD GPU force-merge ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants