Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Remove misleading log #13266

Closed
wants to merge 1 commit into from

Conversation

wangxiyuan
Copy link
Contributor

@wangxiyuan wangxiyuan commented Feb 14, 2025

When loading a local model like:

from vllm import LLM
llm = LLM(model="./opt-125m")

The log will show some info in error level, but actually it doesn't raises any error.

ERROR 02-14 07:06:48 config.py:102] Error retrieving file list: Repo id must use alphanumeric chars or '-', '_', '.', '--' and '..' are forbidden, '-' and '.' cannot start or end the name, max length is 96: './opt-125m'., retrying 1 of 2
ERROR 02-14 07:06:50 config.py:100] Error retrieving file list: Repo id must use alphanumeric chars or '-', '_', '.', '--' and '..' are forbidden, '-' and '.' cannot start or end the name, max length is 96: './opt-125m'.

This PR remove this misleading log.

Related to: #13107

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@wangxiyuan
Copy link
Contributor Author

@maxdebayser @khluu Is this change fine? Thanks.

@maxdebayser
Copy link
Contributor

@wangxiyuan , since this is a local path, I think that vllm shouldn't even enter this retry loop, it should search for the files locally first. Let me try to reproduce this behavior here.

@maxdebayser
Copy link
Contributor

@wangxiyuan , I've opened PR #13292 to fix this behavior. Thanks for reporting the problem!

@wangxiyuan
Copy link
Contributor Author

wangxiyuan commented Feb 16, 2025

see #13292

@wangxiyuan wangxiyuan closed this Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants