-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Fix qwen2.5-vl image processor #13286
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: isotr0py <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Let's update |
Signed-off-by: isotr0py <[email protected]>
We probably should also update this for Qwen2-VL (optionally importing the fast version so it can still be run in v4.48) |
Signed-off-by: isotr0py <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
Get the CI to pass first. Once Qwen team updates their end, we can merge this PR. |
FIX #13285
Need to wait Qwen team update the model repo with correct preprocessor_config.json (see https://huggingface.co/Qwen/Qwen2.5-VL-3B-Instruct/discussions/14)
transformers
removedQwen2_5_VLImageProcessor
in latest commit and replaced withQwen2VLImageProcessor
andQwen2VLImageProcessorFast
instead. (see Add ImageProcessorFast to Qwen2.5-VL processor huggingface/transformers#36164)