Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix qwen2.5-vl image processor #13286

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Feb 14, 2025

FIX #13285

Need to wait Qwen team update the model repo with correct preprocessor_config.json (see https://huggingface.co/Qwen/Qwen2.5-VL-3B-Instruct/discussions/14)

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@Isotr0py Isotr0py requested a review from ywang96 February 14, 2025 11:36
@DarkLight1337
Copy link
Member

DarkLight1337 commented Feb 14, 2025

Let's update isinstance check to consider both the slow and fast version (since the fast version doesn't inherit from the slow version)

Signed-off-by: isotr0py <[email protected]>
@DarkLight1337
Copy link
Member

DarkLight1337 commented Feb 14, 2025

We probably should also update this for Qwen2-VL (optionally importing the fast version so it can still be run in v4.48)

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 14, 2025
@DarkLight1337
Copy link
Member

DarkLight1337 commented Feb 14, 2025

Get the CI to pass first. Once Qwen team updates their end, we can merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Qwen2.5-VL broke due to transformers upstream changes
2 participants