-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add sitemap #87
base: main
Are you sure you want to change the base?
Conversation
Deploying dda-website with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One small comment.
src/pages/sitemap.xml.ts
Outdated
import { datocmsCollection } from '@lib/datocms'; | ||
import type { APIRoute } from 'astro'; | ||
|
||
export const prerender = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
src/pages/sitemap.xml.ts
Outdated
> | ||
<url><loc>${site}</loc></url> | ||
<url><loc>${site}events/</loc></url> | ||
${events.map((event) => `<url><loc>${site}events/${event.details.slug}</loc></url>`).join('\n') } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this a function like generateUrlTags
, since there's some repetition below.
Changes
How to test
/sitemap.xml
Checklist
I have made updated relevant documentation files (in project README, docs/, etc)I have added a decision log entry if the change affects the architecture or changes a significant technology