Improvements and bug fixes #48
Conversation
…t event tag collection
…lt and removed un-necessary quoting of config options
…ed extra dependency introduced in MISP version 2.4.102
| @@ -25,6 +25,7 @@ $config = array ( | |||
| 'live' => <%= @live -%>, | |||
| 'language' => '<%= @language -%>', | |||
| 'enable_advanced_correlations' => <%= @enable_advanced_correlations -%>, | |||
| <% unless @python_bin.nil? -%> 'python_bin' => '<%= @python_bin -%>',<%= "\n" %><% end -%> | |||
There was a problem hiding this comment.
can you add a unit test to ensure this works?
|
Dear @liviuvalsan, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
1 similar comment
|
Dear @liviuvalsan, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Dear @liviuvalsan, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Dear @liviuvalsan, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Pull Request (PR) description
A few improvements and bug fixes
This Pull Request (PR) fixes the following issues
CakeReque version is now a parameter instead of being hardcoded
Changed default event threat level to match the MISP default and added a config option for the default event tag collection
Bug fix: Elasticsearch connection string and index name need to be string escaped
Changed default value for session auto regenerate to match MISP default and removed un-necessary quoting of config options
Changed the default MISP version installed to version 2.4.102 and added extra dependency introduced in MISP version 2.4.102